Re: [PATCH] PCI: dwc: Added link up check in map_bus of dw_child_pcie_ops

From: Rob Herring
Date: Thu Oct 08 2020 - 11:12:30 EST


On Thu, Oct 8, 2020 at 9:47 AM Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> wrote:
>
> On Fri, 2 Oct 2020 at 14:59, Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> wrote:
> >
> > On Thu, 1 Oct 2020 at 22:16, Michael Walle <michael@xxxxxxxx> wrote:
> > >
> > > Am 2020-10-01 15:32, schrieb Kishon Vijay Abraham I:
> > >
> > > > Meanwhile would it be okay to add linkup check atleast for DRA7X so
> > > > that
> > > > we could have it booting in linux-next?
> > >
> > > Layerscape SoCs (at least the LS1028A) are also still broken in
> > > linux-next,
> > > did I miss something here?
> >
> > I have been monitoring linux next boot and functional testing on nxp devices
> > for more than two week and still the problem exists on nxp-ls2088.
> >
> > Do you mind checking the possibilities to revert bad patches on linux next tree
> > and continue to work on fixes please ?
> >
> > suspected bad commit: [ I have not bisected this problem ]
> > c2b0c098fbd1 ("PCI: dwc: Use generic config accessors")
> >
> > crash log snippet:
> > [ 1.563008] SError Interrupt on CPU5, code 0xbf000002 -- SError
> > [ 1.563010] CPU: 5 PID: 1 Comm: swapper/0 Not tainted
> > 5.9.0-rc7-next-20201001 #1
> > [ 1.563011] Hardware name: Freescale Layerscape 2088A RDB Board (DT)
> > [ 1.563013] pstate: 20000085 (nzCv daIf -PAN -UAO -TCO BTYPE=--)
> > [ 1.563014] pc : pci_generic_config_read+0x44/0xe8
> > [ 1.563015] lr : pci_generic_config_read+0x2c/0xe8
>
>
> This reported issue is gone now on Linux next master branch.
> I am not sure which is a fix commit.

There isn't one, better double check that. We're still waiting on
respinning of the revert patch.

BTW, why is the kernelci NXP lab almost always down? I have a branch
now to test things and I'm not done breaking the DWC driver. :)

Rob