Re: [PATCH] arm64: dts imx8mn: Remove non-existent USB OTG2

From: Krzysztof Kozlowski
Date: Thu Oct 08 2020 - 13:09:39 EST


On Thu, Oct 08, 2020 at 10:19:33AM -0500, Adam Ford wrote:
> According to the i.MX8MN TRM, there is only one OTG port. The
> address for OTG2 is reserved on Nano.
>
> This patch removes the non-existent OTG2.
>
> Fixes: 6c3debcbae47 ("arm64: dts: freescale: Add i.MX8MN dtsi support")
>
> Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index 746faf1cf2fb..ac206e1f2dad 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -791,21 +791,6 @@ usbmisc1: usbmisc@32e40200 {
> reg = <0x32e40200 0x200>;
> };
>
> - usbotg2: usb@32e50000 {
> - compatible = "fsl,imx8mn-usb", "fsl,imx7d-usb";
> - reg = <0x32e50000 0x200>;
> - interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clk IMX8MN_CLK_USB1_CTRL_ROOT>;
> - clock-names = "usb1_ctrl_root_clk";
> - assigned-clocks = <&clk IMX8MN_CLK_USB_BUS>,
> - <&clk IMX8MN_CLK_USB_CORE_REF>;
> - assigned-clock-parents = <&clk IMX8MN_SYS_PLL2_500M>,
> - <&clk IMX8MN_SYS_PLL1_100M>;
> - fsl,usbphy = <&usbphynop2>;
> - fsl,usbmisc = <&usbmisc2 0>;
> - status = "disabled";
> - };
> -
> usbmisc2: usbmisc@32e50200 {
> compatible = "fsl,imx8mn-usbmisc", "fsl,imx7d-usbmisc";
> #index-cells = <1>;

Good catch but please also remove usbmisc2 and the usbphy nodes.

Best regards,
Krzysztof