Re: [PATCH] scsi: qla2xxx: fix return of uninitialized value in rval

[Colin Ian King]

On 08/10/2020 19:41, Pavel Machek wrote:
> On Thu 2020-10-08 19:32:39, Colin King wrote:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> A previous change removed the initialization of rval and there is
>> now an error where an uninitialized rval is being returned on an
>> error return path. Fix this by returning -ENODEV.
>>
>> Addresses-Coverity: ("Uninitialized scalar variable")
>> Fixes: b994718760fa ("scsi: qla2xxx: Use constant when it is known")
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> Acked-by: Pavel Machek (CIP) <pavel@xxxxxxx>
> 
> And sorry, I did patch against mainline, and this got added in -next
> in the meantime.

Ah, that explains it. No problem, Coverity is good at finding buglets

Colin

> 
>> index ae47e0eb0311..1f9005125313 100644
>> --- a/drivers/scsi/qla2xxx/qla_nvme.c
>> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
>> @@ -561,7 +561,7 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
>>  	vha = fcport->vha;
>>  
>>  	if (!(fcport->nvme_flag & NVME_FLAG_REGISTERED))
>> -		return rval;
>> +		return -ENODEV;
>>  
>>  	if (test_bit(ABORT_ISP_ACTIVE, &vha->dpc_flags) ||
>>  	    (qpair && !qpair->fw_started) || fcport->deleted)
>> -- 
>> 2.27.0
>>
>