Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

[Coiby Xu]

On Thu, Oct 08, 2020 at 04:39:40PM +0300, Dan Carpenter wrote:
> On Thu, Oct 08, 2020 at 07:58:04PM +0800, Coiby Xu wrote:
> > -static int
> > -qlge_reporter_coredump(struct devlink_health_reporter *reporter,
> > -			struct devlink_fmsg *fmsg, void *priv_ctx,
> > -			struct netlink_ext_ack *extack)
> > +static int fill_seg_(struct devlink_fmsg *fmsg,
> > +		    struct mpi_coredump_segment_header *seg_header,
> > +		    u32 *reg_data)
> >  {
> > -	return 0;
> > +	int i;
> > +	int header_size = sizeof(struct mpi_coredump_segment_header);
>
> Please use the sizeof() directly in the code.  Don't introduce
> indirection if you can help it.
>
> > +	int regs_num = (seg_header->seg_size - header_size) / sizeof(u32);
> > +	int err;
> > +
Thank you for the suggestion!
> regards,
> dan carpenter

--
Best regards,
Coiby