Re: [RFC PATCH 18/24] vhost-vdpa: support ASID based IOTLB API

[Jason Wang]

On 2020/9/28 下午11:44, Eugenio Perez Martin wrote:
> > -                            u64 iova, u64 size)
> > +static int vhost_vdpa_unmap(struct vhost_vdpa *v,
> > +                           struct vhost_iotlb *iotlb,
> > +                           u64 iova, u64 size)
> >   {
> >          struct vdpa_device *vdpa = v->vdpa;
> >          const struct vdpa_config_ops *ops = vdpa->config;
> > +       u32 asid = (iotlb);
> > +
> > +       if (!iotlb)
> > +               return -EINVAL;
> This should be reorder to check for (!iotlb) before use at `asid =
> iotlb_to_asid()`, isn't it?
>
> Thanks!

Yes, will fix in the next version.

Thanks