Re: [PATCH] efi:mokvar-table: fix build error
From: Ard Biesheuvel
Date: Fri Oct 09 2020 - 04:52:44 EST
On Fri, 9 Oct 2020 at 10:51, Xiaoming Ni <nixiaoming@xxxxxxxxxx> wrote:
>
> drivers/firmware/efi/mokvar-table.c:139:5: error: implicit declaration of
> function 'early_memunmap'; did you mean 'devm_memunmap'?
> [-Werror=implicit-function-declaration]
> drivers/firmware/efi/mokvar-table.c:148:9: error: implicit declaration of
> function 'early_memremap'; did you mean 'devm_memremap'?
> [-Werror=implicit-function-declaration]
>
> add #include <asm/early_ioremap.h> to fix this build error
>
> Signed-off-by: Xiaoming Ni <nixiaoming@xxxxxxxxxx>
Thank you Xiaoming. We already have a fix queued up for this issue.
> ---
> drivers/firmware/efi/mokvar-table.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/efi/mokvar-table.c b/drivers/firmware/efi/mokvar-table.c
> index 72a9e1736fef..c23d3686f1c7 100644
> --- a/drivers/firmware/efi/mokvar-table.c
> +++ b/drivers/firmware/efi/mokvar-table.c
> @@ -39,6 +39,7 @@
> #include <linux/kobject.h>
> #include <linux/list.h>
> #include <linux/slab.h>
> +#include <asm/early_ioremap.h>
>
> /*
> * The LINUX_EFI_MOK_VARIABLE_TABLE_GUID config table is a packed
> --
> 2.27.0
>