Re: [PATCH 3/5] firmware: arm_scmi: add config dependency for smc transport
From: Sudeep Holla
Date: Fri Oct 09 2020 - 11:58:25 EST
On Fri, Oct 09, 2020 at 02:33:41PM +0200, Etienne Carriere wrote:
> On Thu, 8 Oct 2020 at 23:08, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
> >
> > On Thu, Oct 08, 2020 at 04:37:20PM +0200, Etienne Carriere wrote:
> > > Fix dependencies for configuration switch ARM_SCMI_PROTOCOL that
> > > is not exclusively dependent on MAILBOX since the alternate
> > > smc transport that is depends on HAVE_ARM_SMCCC_DISCOVERY since [1].
> > >
> >
> > Do you need any build issues ? I don't see why this is needed.
> >
>
> This change is for consistency of the kernel configuration.
> Without this change, a kernel configured without CONFIG_MAILBOX
> cannot embed SCMI support even is using only the SMC transport
> enabled thanks to HAVE_ARM_SMCCC_DISCOVERY.
>
Fair enough, however instead of adding to the list for each added transport
we need to do better transport abstraction now that we have multiple.
I don't see this as critical, let me know if you disagree.
--
Regards,
Sudeep