Re: [PATCH] net: stmmac: Don't call _irqoff() with hardirqs enabled
From: Heiner Kallweit
Date: Fri Oct 09 2020 - 12:06:34 EST
On 09.10.2020 17:58, Jakub Kicinski wrote:
> On Fri, 9 Oct 2020 16:54:06 +0200 Heiner Kallweit wrote:
>> I'm thinking about a __napi_schedule version that disables hard irq's
>> conditionally, based on variable force_irqthreads, exported by the irq
>> subsystem. This would allow to behave correctly with threadirqs set,
>> whilst not loosing the _irqoff benefit with threadirqs unset.
>> Let me come up with a proposal.
>
> I think you'd need to make napi_schedule_irqoff() behave like that,
> right? Are there any uses of napi_schedule_irqoff() that are disabling
> irqs and not just running from an irq handler?
>
Right, the best approach depends on the answer to the latter question.
I didn't check this yet, therefore I described the least intrusive approach.