Re: [PATCH] ata: ahci: mvebu: Make SATA PHY optional for Armada 3720

From: Jens Axboe
Date: Fri Oct 09 2020 - 14:48:14 EST


On 10/9/20 2:42 AM, Pali Rohár wrote:
> Older ATF does not provide SMC call for SATA phy power on functionality and
> therefore initialization of ahci_mvebu is failing when older version of ATF
> is using. In this case phy_power_on() function returns -EOPNOTSUPP.
>
> This patch adds a new hflag AHCI_HFLAG_IGN_NOTSUPP_POWER_ON which cause
> that ahci_platform_enable_phys() would ignore -EOPNOTSUPP errors from
> phy_power_on() call.
>
> It fixes initialization of ahci_mvebu on Espressobin boards where is older
> Marvell's Arm Trusted Firmware without SMC call for SATA phy power.
>
> This is regression introduced in commit 8e18c8e58da64 ("arm64: dts: marvell:
> armada-3720-espressobin: declare SATA PHY property") where SATA phy was
> defined and therefore ahci_platform_enable_phys() on Espressobin started
> failing.

Applied, thanks.

--
Jens Axboe