Re: [PATCH net 1/2] net: ipa: only clear hardware state if setup has completed

From: Jakub Kicinski
Date: Fri Oct 09 2020 - 15:41:40 EST


On Fri, 9 Oct 2020 14:39:45 -0500 Alex Elder wrote:
> > The only call site already checks setup_complete, so this is not needed,
> > no?
>
> Wow, you are correct.
>
> I was mainly focused on the fact that the ipa_modem_crashed()
> call could happen asynchronously, and that it called
> ipa_table_reset() which requires IPA immediate commands.
> I should have followed it back to its callers.
>
> I agree with you, this is not needed. The other patch
> is definitely needed though.
>
> Would you like me to re-post that single patch, or is
> it acceptable as-is?

Please repost, thank you!