Re: [PATCH v6 3/3] i2c: imx: Don't generate STOP condition if arbitration has been lost
From: Wolfram Sang
Date: Sat Oct 10 2020 - 19:03:15 EST
On Fri, Oct 09, 2020 at 01:03:20PM +0200, Christian Eggers wrote:
> If arbitration is lost, the master automatically changes to slave mode.
> I2SR_IBB may or may not be reset by hardware. Raising a STOP condition
> by resetting I2CR_MSTA has no effect and will not clear I2SR_IBB.
>
> So calling i2c_imx_bus_busy() is not required and would busy-wait until
> timeout.
>
> Signed-off-by: Christian Eggers <ceggers@xxxxxxx>
> Tested (not extensively) on Vybrid VF500 (Toradex VF50):
> Tested-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Acked-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # Requires trivial backporting, simple remove
> # the 3rd argument from the calls to
> # i2c_imx_bus_busy().
Applied to for-next, thanks!
Attachment:
signature.asc
Description: PGP signature