Re: [PATCH v3 0/6] iio: sx9310: Support setting various settings

From: Jonathan Cameron
Date: Sat Oct 10 2020 - 19:12:26 EST


On Tue, 6 Oct 2020 18:17:29 -0700
Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:

> I need to configure various settings such as thresholds, gain factors,
> etc. on this device. Some settings matter at boot, while others can wait
> for userspace to configure things. This patch series adds support to
> set these various bits in the registers of this device.

Looks good to me. I've applied them to the togreg branch of iio.git and
pushed out as testing for the autobuilders to see if they can find any
issues. Note that I can still add tags etc for now if anyone
wants to send any!

Thanks,

Jonathan

>
> Changes from v2 (https://lore.kernel.org/r/20200930075728.2410327-1-swboyd@xxxxxxxxxxxx)
> - Rolled in a fix from Gwendal on last patch to simplify if-else logic
> - Fixed binding and picked up Rob's reviewed-by tag
>
> Changes from v1 (https://lore.kernel.org/r/20200903221828.3657250-1-swboyd@xxxxxxxxxxxx)
> - A bunch more patches for userspace settings
> - Removed body thresholds as they're probably not used
> - Removed compensate common as it probably doesn't matter
> - Moved thresholds, gain factor, hysteresis, debounce to userspace
>
> Stephen Boyd (6):
> iio: sx9310: Support hardware gain factor
> iio: sx9310: Support setting proximity thresholds
> iio: sx9310: Support setting hysteresis values
> iio: sx9310: Support setting debounce values
> dt-bindings: iio: sx9310: Add various settings as DT properties
> iio: sx9310: Set various settings from DT
>
> .../iio/proximity/semtech,sx9310.yaml | 63 +++
> drivers/iio/proximity/sx9310.c | 508 +++++++++++++++++-
> 2 files changed, 565 insertions(+), 6 deletions(-)
>
> Cc: Daniel Campello <campello@xxxxxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Cc: Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx>
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Cc: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
> Cc: Evan Green <evgreen@xxxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: <devicetree@xxxxxxxxxxxxxxx>
>
> base-commit: 1bebdcb928eba880f3a119bacb8149216206958a