Re: git grep/sed to standardize "/* SPDX-License-Identifier: <license>"
From: Joe Perches
Date: Sun Oct 11 2020 - 14:47:54 EST
On Sun, 2020-10-11 at 11:42 -0700, Linus Torvalds wrote:
> On Tue, Oct 6, 2020 at 4:13 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
> > Almost all source files in the kernel use a standardized SPDX header
> > at line 1 with a comment /* initiator and terminator */:
> >
> > /* SPDX-License-Identifier: <license> */
> >
> > $ git grep -PHn '^/\* SPDX-License-Identifier:.*\*/\s*$' | \
> > wc -l
> > 17847
>
> That grep pattern makes zero sense.
>
> Why would */ be special at all? It isn't.
>
> $ git grep SPDX-License-Identifier: | wc -l
> 52418
>
> and a *LOT* of those are shell scripts and use "#", or are C sources
> and use "//" etc.
>
> So your "standardization" is completely pointless. Anybody who expects
> that pattern just doing something fundamentally wrong, because the
> pattern you want to standardize around is simply not valid.
It's just a trivial grep pattern to determine if the c90 style
SPDX-License-Identifier is in an individual single line comment.
Almost all are.