Re: [PATCH v9 4/6] fpga: dfl: move dfl bus related APIs to include/linux/fpga/dfl.h

[Xu Yilun]

On Sun, Oct 11, 2020 at 04:45:22PM +0200, Greg KH wrote:
> On Sat, Oct 10, 2020 at 03:09:51PM +0800, Xu Yilun wrote:
> > Now the dfl drivers could be made as independent modules and put in
> > different folders according to their functionalities. In order for
> > scattered dfl device drivers to include dfl bus APIs, move the
> > dfl bus APIs to a new header file in the public folder.
> > 
> > [mdf@xxxxxxxxxx: Fixed up MAINTAINERS entry merge]
> > Signed-off-by: Xu Yilun <yilun.xu@xxxxxxxxx>
> > Reviewed-by: Tom Rix <trix@xxxxxxxxxx>
> > Acked-by: Wu Hao <hao.wu@xxxxxxxxx>
> > Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx>
> > ---
> > v2: updated the MAINTAINERS under FPGA DFL DRIVERS
> >     improve the comments
> >     rename the dfl-bus.h to dfl.h
> > v3: rebase the patch for previous changes
> > v9: rebase the patch for bus name changes back to "dfl"
> > ---
> >  MAINTAINERS              |  1 +
> >  drivers/fpga/dfl.c       |  1 +
> >  drivers/fpga/dfl.h       | 72 ----------------------------------------
> >  include/linux/fpga/dfl.h | 86 ++++++++++++++++++++++++++++++++++++++++++++++++
> 
> Why in the fpga directory?

OK, since the dfl could be independent to fpga, I think it could be put in include/linux.

Thanks,
Yilun

> 
> thanks,
> 
> greg k-h