Re: [kbuild-all] Re: drivers/power/supply/mp2629_charger.c:522:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.

From: Rong Chen
Date: Mon Oct 12 2020 - 01:36:37 EST




On 10/9/20 10:27 PM, Andy Shevchenko wrote:
On Fri, Oct 9, 2020 at 4:23 PM kernel test robot <lkp@xxxxxxxxx> wrote:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 549738f15da0e5a00275977623be199fbbf7df50
commit: 3bc6d790c39dfc4539c36525e6bcb617abbae467 power: supply: Add support for mps mp2629 battery charger
date: 4 months ago
:::::: branch date: 12 hours ago
:::::: commit date: 4 months ago
compiler: sh4-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
...

3bc6d790c39dfc Saravanan Sekar 2020-05-26 514 unsigned int rval;
3bc6d790c39dfc Saravanan Sekar 2020-05-26 515 int ret;
3bc6d790c39dfc Saravanan Sekar 2020-05-26 516
3bc6d790c39dfc Saravanan Sekar 2020-05-26 517 ret = regmap_read(charger->regmap, MP2629_REG_IMPEDANCE_COMP, &rval);
3bc6d790c39dfc Saravanan Sekar 2020-05-26 518 if (ret)
3bc6d790c39dfc Saravanan Sekar 2020-05-26 519 return ret;
3bc6d790c39dfc Saravanan Sekar 2020-05-26 520
3bc6d790c39dfc Saravanan Sekar 2020-05-26 521 rval = (rval >> 4) * 10;
3bc6d790c39dfc Saravanan Sekar 2020-05-26 @522 return sprintf(buf, "%d mohm\n", rval);
3bc6d790c39dfc Saravanan Sekar 2020-05-26 523 }
Right, should be %u. Can LKP generate this type of patches?


Hi Andy,

Thanks for the advice, is there a auto correct tool to do such thing?
I afraid we can't cover all the circumstances.

Best Regards,
Rong Chen