Re: [PATCH v2 1/4 RESEND] MIPS: Loongson64: Select SMP in Kconfig to avoid build error

From: Thomas Bogendoerfer
Date: Mon Oct 12 2020 - 06:38:33 EST


On Sun, Oct 11, 2020 at 07:47:51AM +0800, Tiezhu Yang wrote:
> In the current code, CONFIG_SMP can be set as N by user on the Loongson
> platform, then there exists the following build error under !CONFIG_SMP:
>
> CC arch/mips/kernel/asm-offsets.s
> In file included from ./include/linux/gfp.h:9:0,
> from ./include/linux/xarray.h:14,
> from ./include/linux/radix-tree.h:18,
> from ./include/linux/fs.h:15,
> from ./include/linux/compat.h:17,
> from arch/mips/kernel/asm-offsets.c:12:
> ./include/linux/topology.h: In function 'numa_node_id':
> ./include/linux/topology.h:119:2: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration]
> return cpu_to_node(raw_smp_processor_id());
> ^
> cc1: some warnings being treated as errors
> scripts/Makefile.build:117: recipe for target 'arch/mips/kernel/asm-offsets.s' failed
> make[1]: *** [arch/mips/kernel/asm-offsets.s] Error 1
>
> Select SMP in Kconfig to avoid the above build error and then remove
> CONFIG_SMP=y in loongson3_defconfig.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
> ---
>
> v2: no changes
>
> arch/mips/Kconfig | 1 +
> arch/mips/configs/loongson3_defconfig | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]