Re: [PATCH V2 1/3] arm64: dts: imx8mm: Correct WDOG_B pin configuration
From: Krzysztof Kozlowski
Date: Mon Oct 12 2020 - 09:04:49 EST
On Mon, Oct 12, 2020 at 08:44:00PM +0800, Anson Huang wrote:
> Different revision of i.MX8MM EVK boards may have different external
> pull up registor design, some are enabled while some are NOT, to make
> sure the WDOG_B pin works properly, better to enable internal pull up
> resistor. Since enabling internal pull up resistor is NOT harmful and
> having benefit of flexibility on different board design, just enable
> it for all i.MX8MM boards; And schmitt input is NOT necessary for this
> WDOG_B output pin, so remove it; Open drain outputs provide more
> flexibility to a designer as they can be pulled-up to any voltage found
> in the system, so enable it as well.
>
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> ---
> Changes since V1:
> - Provide more explanation of removing schmitt input and enabling open drain in commit msg.
> ---
> arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Best regards,
Krzysztof