RE: [PATCH v2 1/1] i2c: ocores: fix polling mode workaround on FU540-C000 SoC

From: Sagar Kadam
Date: Mon Oct 12 2020 - 11:49:25 EST



> -----Original Message-----
> From: Andreas Schwab <schwab@xxxxxxxxxxxxxx>
> Sent: Friday, October 9, 2020 11:55 PM
> To: Sagar Kadam <sagar.kadam@xxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-riscv@xxxxxxxxxxxxxxxxxxx; linux-
> i2c@xxxxxxxxxxxxxxx; peter@xxxxxxxxxxxxx; andrew@xxxxxxx; Paul
> Walmsley ( Sifive) <paul.walmsley@xxxxxxxxxx>; palmer@xxxxxxxxxxx;
> aou@xxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 1/1] i2c: ocores: fix polling mode workaround on
> FU540-C000 SoC
>
> [External Email] Do not click links or attachments unless you recognize the
> sender and know the content is safe
>
> On Okt 09 2020, Sagar Shrikant Kadam wrote:
>
> > diff --git a/drivers/i2c/busses/i2c-ocores.c
> > b/drivers/i2c/busses/i2c-ocores.c index f5fc75b..9b3d1ab 100644
> > --- a/drivers/i2c/busses/i2c-ocores.c
> > +++ b/drivers/i2c/busses/i2c-ocores.c
> > @@ -686,17 +686,21 @@ static int ocores_i2c_probe(struct
> > platform_device *pdev)
> >
> > init_waitqueue_head(&i2c->wait);
> >
> > + /*
> > + * Set OCORES_FLAG_BROKEN_IRQ to enable workaround for
> > + * FU540-C000 SoC in polling mode.
> > + * Since the SoC does have interrupt it's dt has the interrupt
>
> Typo: its
>

Thanks Andreas,
I will submit v3 with the change.

BR,
Sagar
> Andreas.
>
> --
> Andreas Schwab, schwab@xxxxxxxxxxxxxx
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA
> AEC1 "And now for something completely different."