Re: [PATCH v1 03/15] perf data: open data directory in read access mode

[Andi Kleen]

On Mon, Oct 12, 2020 at 11:55:07AM +0300, Alexey Budankov wrote:
> 
> Open files located at data directory in case of read access mode.

Need some rationale. Is this a bug fix? Did the case not matter
before?

> 
> Signed-off-by: Alexey Budankov <alexey.budankov@xxxxxxxxxxxxxxx>
> ---
>  tools/perf/util/data.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> index c47aa34fdc0a..6ad61ac6ba67 100644
> --- a/tools/perf/util/data.c
> +++ b/tools/perf/util/data.c
> @@ -321,6 +321,10 @@ static int open_dir(struct perf_data *data)
>  		return -1;
>  
>  	ret = open_file(data);
> +	if (!ret && perf_data__is_dir(data)) {
> +		if (perf_data__is_read(data))
> +			ret = perf_data__open_dir(data);
> +	}
>  
>  	/* Cleanup whatever we managed to create so far. */
>  	if (ret && perf_data__is_write(data))
> -- 
> 2.24.1
> 
>