Re: [PATCH -v4] checkpatch: Check for .byte-spelled insn opcodes documentation on x86
From: Joe Perches
Date: Mon Oct 12 2020 - 13:40:12 EST
On Mon, 2020-10-12 at 19:31 +0200, Borislav Petkov wrote:
> On Mon, Oct 12, 2020 at 10:17:56AM -0700, Joe Perches wrote:
> > Workie here. This is against -next.
>
> Nevermind - I had an old version in that branch.
>
> What I mind to, however, is:
>
> "adding a mechanism to only emit the message once per patched file (Joe)"
>
> This needs to happen for every .byte line which doesn't have a comment
> documenting the binutils version.
Why? I think it unnecessary.
It's noisy and would also be duplicative in the code.
/* binutils version x.y */
#define __ASM_CLAC ".byte 0x0f,0x01,0xca"
#define __ASM_STAC ".byte 0x0f,0x01,0xcb"
Both should not need separate binutils version info
if added in a patch context.