Re: [PATCH 2/2] dt-bindings: arm: sunxi: Fix Orange Pi Zero bindings
From: Ondřej Jirman
Date: Mon Oct 12 2020 - 16:03:30 EST
Hello Michal,
On Mon, Oct 12, 2020 at 08:04:02PM +0200, Michal Suchánek wrote:
> On Mon, Oct 12, 2020 at 04:47:53PM +0200, Maxime Ripard wrote:
> > On Thu, Oct 08, 2020 at 08:40:06PM +0200, Michal Suchanek wrote:
> > > There are two models of Orange Pi zero which are confusingly marketed
> > > under the same name. Old model comes without a flash memory and current
> > > model does have a flash memory. Add bindings for each model.
> > >
> > > Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx>
> >
> > Unfortunately, changing a compatible or a DT filename is not an option
>
> So how do you handle the situation when you find out that there are two
> different devices marketed under the same name?
>
> Surely the device tree is labaled by the device name but now you need
> two device trees that describe the two devices.
You can for example make the new DT name *-flash.dts, instead
of changing the name of existing DT to *-noflash.dts. Or if there's
a version number on the PCB that differs from the older variant,
use that version to differentiate the newer board DT.
regards,
o.
> Thanks
>
> Michal