Re: [PATCH v2 2/3] mm/slub: Fix redzoning for small allocations

From: Kees Cook
Date: Mon Oct 12 2020 - 16:43:35 EST


On Mon, Oct 12, 2020 at 08:01:04AM +0000, Christopher Lameter wrote:
> On Fri, 9 Oct 2020, Kees Cook wrote:
>
> > Store the freelist pointer out of line when object_size is smaller than
> > sizeof(void *) and redzoning is enabled.
> >
> > (Note that no caches with such a size are known to exist in the kernel
> > currently.)
>
> Ummm... The smallest allowable cache size is sizeof(void *) as I recall.
>
>
> mm/slab_common.c::kmem_sanity_check() checks the sizes when caches are
> created.

Ah thank you! Yes, I really thought there was a place where that
happened, but I missed it. This patch can be dropped.

--
Kees Cook