RE: [PATCH 00/15] dmaengine: dw-axi-dmac: support Intel KeemBay AxiDMA
From: Sia, Jee Heng
Date: Tue Oct 13 2020 - 01:49:42 EST
> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: 12 October 2020 9:59 PM
> To: Sia, Jee Heng <jee.heng.sia@xxxxxxxxx>
> Cc: vkoul@xxxxxxxxxx; Eugeniy.Paltsev@xxxxxxxxxxxx;
> dmaengine@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 00/15] dmaengine: dw-axi-dmac: support Intel KeemBay
> AxiDMA
>
> On Mon, Oct 12, 2020 at 12:21:45PM +0800, Sia Jee Heng wrote:
> > The below patch series are to support AxiDMA running on Intel KeemBay SoC.
> > The base driver is dw-axi-dmac but code refactoring is needed, for example:
> > - Support YAML Schemas DT binding.
> > - Replacing Linked List with virtual descriptor management.
> > - Remove unrelated hw desc stuff from dma memory pool.
> > - Manage dma memory pool alloc/destroy based on channel activity.
> > - Support dmaengine device_sync() callback.
> > - Support dmaengine device_config().
> > - Support dmaegnine device_prep_slave_sg().
> > - Support dmaengine device_prep_dma_cyclic().
> > - Support of_dma_controller_register().
> > - Support burst residue granularity.
> > - Support Intel KeemBay AxiDMA registers.
> > - Support Intel KeemBay AxiDMA device handshake.
> > - Support Intel KeemBay AxiDMA BYTE and HALFWORD device operation.
> > - Add constraint to Max segment size.
> >
> > This patch set is to replace the patch series submitted at:
> > https://lore.kernel.org/dmaengine/1599213094-30144-1-git-send-email-je
> > e.heng.sia@xxxxxxxxx/
>
> And it means effectively the bumped version, besides the fact that you double
> sent this one...
>
>
> Please fix and resend. Note, now is merge window is open. Depends on
> maintainer's flow it may be good or bad time to resend with properly formed
> changelog and version of the series.
[>>] Thanks. Will resend the patch set with v1 in the header.
>
> > This patch series are tested on Intel KeemBay platform.
> >
> >
> > Sia Jee Heng (15):
> > dt-bindings: dma: Add YAML schemas for dw-axi-dmac
> > dmaengine: dw-axi-dmac: simplify descriptor management
> > dmaengine: dw-axi-dmac: move dma_pool_create() to
> > alloc_chan_resources()
> > dmaengine: dw-axi-dmac: Add device_synchronize() callback
> > dmaengine: dw-axi-dmac: Add device_config operation
> > dmaengine: dw-axi-dmac: Support device_prep_slave_sg
> > dmaegine: dw-axi-dmac: Support device_prep_dma_cyclic()
> > dmaengine: dw-axi-dmac: Support of_dma_controller_register()
> > dmaengine: dw-axi-dmac: Support burst residue granularity
> > dmaengine: dw-axi-dmac: Add Intel KeemBay AxiDMA support
> > dt-binding: dma: dw-axi-dmac: Add support for Intel KeemBay AxiDMA
> > dmaengine: dw-axi-dmac: Add Intel KeemBay DMA register fields
> > dmaengine: dw-axi-dmac: Add Intel KeemBay AxiDMA handshake
> > dmaengine: dw-axi-dmac: Add Intel KeemBay AxiDMA BYTE and HALFWORD
> > registers
> > dmaengine: dw-axi-dmac: Set constraint to the Max segment size
> >
> > .../bindings/dma/snps,dw-axi-dmac.txt | 39 -
> > .../bindings/dma/snps,dw-axi-dmac.yaml | 149 ++++
> > .../dma/dw-axi-dmac/dw-axi-dmac-platform.c | 696 +++++++++++++++---
> > drivers/dma/dw-axi-dmac/dw-axi-dmac.h | 33 +-
> > 4 files changed, 783 insertions(+), 134 deletions(-) delete mode
> > 100644 Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt
> > create mode 100644
> > Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> >
> > --
> > 2.18.0
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>