Re: [PATCH v2] sched/features: Fix !CONFIG_JUMP_LABEL case

[Juri Lelli]

On 13/10/20 10:26, Patrick Bellasi wrote:
> 
> On Tue, Oct 13, 2020 at 07:31:14 +0200, Juri Lelli <juri.lelli@xxxxxxxxxx> wrote...
> 
> > Commit 765cc3a4b224e ("sched/core: Optimize sched_feat() for
> > !CONFIG_SCHED_DEBUG builds") made sched features static for
> > !CONFIG_SCHED_DEBUG configurations, but overlooked the CONFIG_
> > SCHED_DEBUG enabled and !CONFIG_JUMP_LABEL cases. For the latter echoing
> > changes to /sys/kernel/debug/sched_features has the nasty effect of
> > effectively changing what sched_features reports, but without actually
> > changing the scheduler behaviour (since different translation units get
> > different sysctl_sched_features).
> 
> Hops, yes, I think I missed to properly check that config :/
> Good spot!
> 
> > Fix CONFIG_SCHED_DEBUG and !CONFIG_JUMP_LABEL configurations by properly
> > restructuring ifdefs.
> >
> > Fixes: 765cc3a4b224e ("sched/core: Optimize sched_feat() for !CONFIG_SCHED_DEBUG builds")
> > Co-developed-by: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
> > Signed-off-by: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
> > Signed-off-by: Juri Lelli <juri.lelli@xxxxxxxxxx>
> 
> (did you get some wrong formatting for the changelog above?)

Hummm, what you mean?

I intended to follow

https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L566