Re: [PATCH] tracing: add tgid into common field

[Yafang Shao]

On Tue, Oct 13, 2020 at 9:05 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Tue, 13 Oct 2020 13:54:54 +0800
> Yafang Shao <laoar.shao@xxxxxxxxx> wrote:
>
> > --- a/include/linux/trace_events.h
> > +++ b/include/linux/trace_events.h
> > @@ -67,6 +67,7 @@ struct trace_entry {
> >       unsigned char           flags;
> >       unsigned char           preempt_count;
> >       int                     pid;
> > +     int                     tgid;
> >  };
> >
>
> Sorry, this adds another 4 bytes to *every* event, if you want it to or
> not. I'd rather have some ways to remove fields from this header, and not
> add more to it.
>
> I can't take this patch.
>

Right, that is an overhead. I will think about some ways to avoid adding it.


-- 
Thanks
Yafang