Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node

From: Matthias Brugger
Date: Tue Oct 13 2020 - 11:29:14 EST




On 13/10/2020 11:06, Fabien Parent wrote:
Hi Matthias,

Any reason you don't enable the status in the pumpkin dts?

No particular reasons. I looked at what other MTK SoC did for this IP,
and half went with the status to be disabled and the other half went
with an enabled status. So I went the mt8183 way since it is the last
MTK SoC to have been merged and disabled by default. If you think it
is better to be enabled by default, I can change it, I don't have any
strong opinion about this.


Well on mt8183 it is missing the thermal driver although as you can read the values via sysfs I'd say to enable it. No need to resend just because of that. I'll take the patch as-is as soon as Jonathan takes 1/2.

Regards,
Matthias