Re: [PATCH] iio: adc: mediatek: fix unset field

[Matthias Brugger]

On 12/10/2020 21:46, Fabien Parent wrote:
> dev_comp field is used in a couple of places but it is never set. This
> results in kernel oops when dereferencing a NULL pointer. Set the
> `dev_comp` field correctly in the probe function.
>
> Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")
>
> Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>

Ouch.

Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>

> ---
>   drivers/iio/adc/mt6577_auxadc.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
> index ac415cb089cd..7bd48377cd79 100644
> --- a/drivers/iio/adc/mt6577_auxadc.c
> +++ b/drivers/iio/adc/mt6577_auxadc.c
> @@ -276,6 +276,8 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
>   		goto err_disable_clk;
>   	}
>   
> +	adc_dev->dev_comp = of_device_get_match_data(&pdev->dev);
> +
>   	mutex_init(&adc_dev->lock);
>   
>   	mt6577_auxadc_mod_reg(adc_dev->reg_base + MT6577_AUXADC_MISC,