Re: [PATCH v1 03/15] perf data: open data directory in read access mode

[Arnaldo Carvalho de Melo]

Em Mon, Oct 12, 2020 at 07:52:33PM +0300, Alexey Budankov escreveu:
> 
> On 12.10.2020 19:03, Andi Kleen wrote:
> > On Mon, Oct 12, 2020 at 11:55:07AM +0300, Alexey Budankov wrote:
> >>
> >> Open files located at data directory in case of read access mode.
> > 
> > Need some rationale. Is this a bug fix? Did the case not matter
> > before?
> 
> This is not a bug fix. The case didn't matter before.

In such cases can you please write a paragraph explaining why it didn't
matter before and now it is required?

- Arnaldo
 
 > 
> >>
> >> Signed-off-by: Alexey Budankov <alexey.budankov@xxxxxxxxxxxxxxx>
> >> ---
> >>  tools/perf/util/data.c | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> >> index c47aa34fdc0a..6ad61ac6ba67 100644
> >> --- a/tools/perf/util/data.c
> >> +++ b/tools/perf/util/data.c
> >> @@ -321,6 +321,10 @@ static int open_dir(struct perf_data *data)
> >>  		return -1;
> >>  
> >>  	ret = open_file(data);
> >> +	if (!ret && perf_data__is_dir(data)) {
> >> +		if (perf_data__is_read(data))
> >> +			ret = perf_data__open_dir(data);
> >> +	}
> >>  
> >>  	/* Cleanup whatever we managed to create so far. */
> >>  	if (ret && perf_data__is_write(data))
> >> -- 
> >> 2.24.1
> 
> Alexei
> 

-- 

- Arnaldo