Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228

[Guenter Roeck]

On 10/13/20 11:18 AM, Alex Qiu wrote:
> (Intercepting the email thread...)
> 
> Hi Grant,
> 
> Looks like you made a typo in your patch:
> 
>> + case raa_dmpvr2_2rail_nontc:
>> + info->func[0] &= ~PMBUS_HAVE_TEMP;
>> + info->func[1] &= ~PMBUS_HAVE_TEMP;
>> + fallthrough;
> 
> Did you mean "/* fallthrough */" instead of "fallthrough;"?
> 

No, that is the fancy new way to indicate fallthrough in the kernel.
It is converted to either
	__attribute__((__fallthrough__))
or to
	do {} while (0)
in include/linux/compiler_attributes.h.

Guenter