Re: [PATCH] interconnect: qcom: sdm845: Enable keepalive for the MM1 BCM

From: Mike Tipton
Date: Tue Oct 13 2020 - 21:10:28 EST


On 10/12/2020 12:40 PM, Georgi Djakov wrote:
After enabling interconect scaling for display on the db845c board,
s/interconect/interconnect/

in certain configurations the board hangs, while the following errors
are observed on the console:

Error sending AMC RPMH requests (-110)
qcom_rpmh TCS Busy, retrying RPMH message send: addr=0x50000
qcom_rpmh TCS Busy, retrying RPMH message send: addr=0x50000
qcom_rpmh TCS Busy, retrying RPMH message send: addr=0x50000
...

In this specific case, the above is related to one of the sequencers
being stuck, while client drivers are returning from probe and trying
to disable the currently unused clock and interconnect resources.
Generally we want to keep the multimedia NoC enabled like the rest of
the NoCs, so let's set the keepalive flag on it too.

Fixes: aae57773fbe0 ("interconnect: qcom: sdm845: Split qnodes into their respective NoCs")
Reported-by: Amit Pundir <amit.pundir@xxxxxxxxxx>
Signed-off-by: Georgi Djakov <georgi.djakov@xxxxxxxxxx>
---
drivers/interconnect/qcom/sdm845.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Mike Tipton <mdtipton@xxxxxxxxxxxxxx>