Re: [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS

From: Joe Perches
Date: Wed Oct 14 2020 - 02:58:43 EST


On Wed, 2020-10-14 at 08:47 +0200, Lukas Bulwahn wrote:
>
> On Tue, 13 Oct 2020, Joe Perches wrote:
>
> > On Wed, 2020-10-14 at 08:36 +0200, Lukas Bulwahn wrote:
> > > On Tue, 13 Oct 2020, Joe Perches wrote:
> > >
> > > > On Wed, 2020-10-14 at 08:21 +0200, Lukas Bulwahn wrote:
> > > > > What does checkpatch.pl warn about and what does clang-format still warn
> > > > > about, which is generally accepted okay as style in the kernel?
> > > >
> > > > clang-format doesn't warn at all, it just reformats.
> > > >
> > > You can run clang-format with --dry-run and then it would just state the
> > > proposed changes, right?
> >
> > clang-format through at least version 10 does not have
> > a --dry-run option.
> >
> >
>
> Just a quick check:
>
> version 9 does not have the --dry-run option:
>
> https://releases.llvm.org/9.0.0/tools/clang/docs/ClangFormat.html
>
> version 10 does:
>
> https://releases.llvm.org/10.0.0/tools/clang/docs/ClangFormat.html

Perhaps some version 10 variants do, but 10.0.0 does not.

$ which clang-format
/usr/local/bin/clang-format
$ clang-format --version
clang-format version 10.0.0 (git://github.com/llvm/llvm-project.git 305b961f64b75e73110e309341535f6d5a48ed72)
$ clang-format --dry-run
clang-format: Unknown command line argument '--dry-run'. Try: 'clang-format --help'
clang-format: Did you mean ' --debug'?