Re: [PATCH next] iommu: intel: don't dereference iommu_device if IOMMU_API is not built

[Lu Baolu]

Hi Bartosz,

On 10/14/20 3:18 PM, Bartosz Golaszewski wrote:
> On Wed, Oct 14, 2020 at 2:49 AM Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> wrote:
> > On 10/13/20 3:30 PM, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > >
> > > Since commit c40aaaac1018 ("iommu/vt-d: Gracefully handle DMAR units
> > > with no supported address widths") dmar.c needs struct iommu_device to
> > > be selected. We can drop this dependency by not dereferencing struct
> > > iommu_device if IOMMU_API is not selected and by reusing the information
> > > stored in iommu->drhd->ignored instead.
> > >
> > > This fixes the following build error when IOMMU_API is not selected:
> > >
> > > drivers/iommu/intel/dmar.c: In function ‘free_iommu’:
> > > drivers/iommu/intel/dmar.c:1139:41: error: ‘struct iommu_device’ has no member named ‘ops’
> > >    1139 |  if (intel_iommu_enabled && iommu->iommu.ops) {
> > >                                                   ^
> > >
> > > Fixes: c40aaaac1018 ("iommu/vt-d: Gracefully handle DMAR units with no supported address widths")
> > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> >
> > With commit title adjusted to "iommu/vt-d: Don't dereference
> > iommu_device if IOMMU_API is not built",
> >
> > Acked-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
>
> Do you want me to resend it again with a changed title or can you fix
> it up when applying? Or should someone else pick it up?

I suppose Joerg will pick this up. I guess you don't need to resend it
unless Joerg asks you to do.

Best regards,
baolu