Re: [PATCH 2/5] dt-bindings: gpio: Add a binding header for the MSC313 GPIO driver

From: Daniel Palmer
Date: Wed Oct 14 2020 - 05:46:08 EST


Hi Rob,

On Tue, 13 Oct 2020 at 01:11, Rob Herring <robh@xxxxxxxxxx> wrote:
<snip>
> > MAINTAINERS | 1 +
> > include/dt-bindings/gpio/msc313-gpio.h | 95 ++++++++++++++++++++++++++
> > 2 files changed, 96 insertions(+)
> > create mode 100644 include/dt-bindings/gpio/msc313-gpio.h
>
> This should be part of the previous patch to avoid the error.

Would reordering the patches to make this header before the yaml file
be acceptable?
The commit message might be pretty big with them squashed into one.

<snip>
> > @@ -0,0 +1,95 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
>
> Don't use DT on non-GPL systems?

Good point. I didn't really think about the header also being used for
something like FreeBSD.
I'll fix that.

Cheers,

Daniel