Re: [PATCH 1/3] thermal: power_allocator: respect upper and lower bounds for cooling device
From: Daniel Lezcano
Date: Wed Oct 14 2020 - 08:31:24 EST
On 07/10/2020 14:22, Lukasz Luba wrote:
> The thermal cooling device specified in DT might be instantiated for
> a thermal zone trip point with a limited set of OPPs to operate on. This
> configuration should be supported by Intelligent Power Allocation (IPA),
> since it is a standard for other governors. Change the code and allow IPA
> to get power value of lower and upper bound set for a given cooling
> device.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@xxxxxxx>
> ---
> drivers/thermal/gov_power_allocator.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
> index dd59085f38f5..f9ee7787b325 100644
> --- a/drivers/thermal/gov_power_allocator.c
> +++ b/drivers/thermal/gov_power_allocator.c
> @@ -96,7 +96,8 @@ static u32 estimate_sustainable_power(struct thermal_zone_device *tz)
> if (instance->trip != params->trip_max_desired_temperature)
> continue;
>
> - if (power_actor_get_min_power(cdev, tz, &min_power))
> + if (cdev->ops->state2power(cdev, tz, instance->upper,
> + &min_power))
if (cdev->ops->state2power && cdev->ops->state2power(cdev, tz,
instance->upper,
&min_power))
?
> continue;
>
> sustainable_power += min_power;
> @@ -404,7 +405,8 @@ static int allocate_power(struct thermal_zone_device *tz,
>
> weighted_req_power[i] = frac_to_int(weight * req_power[i]);
>
> - if (power_actor_get_max_power(cdev, tz, &max_power[i]))
> + if (cdev->ops->state2power(cdev, tz, instance->lower,
> + &max_power[i]))
> continue;
Same here ?
> total_req_power += req_power[i];
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog