Re: [PATCH 09/11] [DEBUG] firmware: arm_scmi: add example SCMI driver for custom protocol

[Randy Dunlap]

Hi,

On 10/14/20 8:05 AM, Cristian Marussi wrote:
> Add an example SCMI driver using custom vendor protocol 0x99 and also
> registering for Performance protocol notifications.
> 
> Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx>
> ---
>  drivers/firmware/Kconfig                      |   7 +
>  drivers/firmware/arm_scmi/Makefile            |   2 +
>  drivers/firmware/arm_scmi/scmi_custom_dummy.c | 126 ++++++++++++++++++
>  3 files changed, 135 insertions(+)
>  create mode 100644 drivers/firmware/arm_scmi/scmi_custom_dummy.c
> 
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 75e2668a6490..d209df6fd3ee 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -48,6 +48,13 @@ config ARM_SCMI_POWER_DOMAIN
>  	  will be called scmi_pm_domain. Note this may needed early in boot
>  	  before rootfs may be available.
>  
> +config ARM_SCMI_CUSTOM_DUMMY
> +	tristate "SCMI Custom Dummy driver"
> +	depends on ARM_SCMI_PROTOCOL_CUSTOM || (COMPILE_TEST && OF)

Just an info note here: <linux/of.h> has lots of stubs for when CONFIG_OF is not
set/enabled, so COMPILE_TEST is usually enough of a dependency without adding "OF".

> +	default n
> +	help
> +	  Custom Dummy driver


-- 
~Randy