Re: [PATCH] checkpatch: add new exception to repeated word check

From: Dwaipayan Ray
Date: Wed Oct 14 2020 - 12:34:04 EST


On Wed, Oct 14, 2020 at 9:47 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Wed, 2020-10-14 at 19:26 +0530, Dwaipayan Ray wrote:
> > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test")
> > moved the repeated word test to check for more file types. But after
> > this, if checkpatch.pl is run on MAINTAINERS, it generates several
> > new warnings of the type:
> >
> > WARNING: Possible repeated word: 'git'
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -3063,7 +3063,7 @@ sub process {
> > }
> >
> > next if ($first ne $second);
> > - next if ($first eq 'long');
> > + next if ($first =~ /(?:long|git)$/);
>
> Nak. This needs a leading ^ otherwise words
> like "belong" and "digit" match as well.
>
> next if ($first =~ /^(?:long|git)$/);
>
>

Yikes, that was silly of me. I will correct and send you the
updated version.

Thanks,
Dwaipayan.