Re: [PATCH v2] perf bench: Use condition variables in numa.
From: Arnaldo Carvalho de Melo
Date: Wed Oct 14 2020 - 13:27:31 EST
Em Wed, Oct 14, 2020 at 06:14:18PM +0200, Jiri Olsa escreveu:
> On Wed, Oct 14, 2020 at 08:39:51AM -0700, Ian Rogers wrote:
> > The pthread_mutex_lock avoids any race on g->nr_tasks_started and
> > g->p.nr_tasks is set up in init() along with all the global state. I
> > don't think there's any race on g->nr_tasks_started and doing a signal
> > for every thread starting will just cause unnecessary wake-ups for the
> > main thread. I think it is better to keep it. I added loops on all the
> > pthread_cond_waits so the code is robust against spurious wake ups.
>
> ah, I missed that mutex call
>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
Thanks, applied.
- Arnaldo