Re: [PATCH 6/6] dt-bindings: misc: correct the property name cmd-gpios to cmd-gpio

From: Lubomir Rintel
Date: Thu Oct 15 2020 - 03:20:54 EST


Hi,

On Wed, Oct 14, 2020 at 12:08:45AM +0800, Zhen Lei wrote:
> The property name used in arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts is
> cmd-gpio.
>
> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:235:
> cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>;
>
> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>

Thanks for the patch.

I've sent out an equivalent one some time ago:
https://lore.kernel.org/lkml/20200925234805.228251-3-lkundrak@xxxxx/

In any case, either is fine with me.

Acked-by: Lubomir Rintel <lkundrak@xxxxx>

> ---
> Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
> index b3c45c046ba5e37..c7a06a9650db2ed 100644
> --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
> +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
> @@ -24,7 +24,7 @@ properties:
> compatible:
> const: olpc,xo1.75-ec
>
> - cmd-gpios:
> + cmd-gpio:
> description: GPIO uspecifier of the CMD pin
> maxItems: 1
>
> @@ -32,7 +32,7 @@ properties:
>
> required:
> - compatible
> - - cmd-gpios
> + - cmd-gpio
>
> additionalProperties: false
>
> @@ -49,7 +49,7 @@ examples:
> slave {
> compatible = "olpc,xo1.75-ec";
> spi-cpha;
> - cmd-gpios = <&gpio 155 GPIO_ACTIVE_HIGH>;
> + cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>;
> };
> };
>
> --
> 1.8.3
>
>