Re: [PATCH v1 0/8] perf c2c: Refine the organization of metrics
From: Leo Yan
Date: Thu Oct 15 2020 - 11:05:24 EST
Hi Joe,
On Wed, Oct 14, 2020 at 02:38:19PM -0400, Joe Mario wrote:
[...]
> > This patch set is to refine metrics output organization.
[...]
> Hi Leo:
> I ran your patches through some perf c2c tests and it all looks good.
> I agree the new format of the "Shared Data Cache Line Table" makes more sense now. And it still holds together nicely when sorted on local HitMs (-d lcl).
>
> Thank you for doing this.
> Joe
>
> Tested-by: Joe Mario <jmario@xxxxxxxxxx>
Thank you for quick response and testing.
I share the same thinking with Jiri that we should respect the existed
usages and habits of the tool, I was also a bit concern that my changes
might introduce inconvinence for others. But it's great that receive
your agreement for the changes!
I have respinned the patch set v2 [1] with adding your test tag and
updated documentation; furthermore, I sent out another patch set for
enhancement perf c2c with sorting on LLC load hit, you are welcome to
reivew and comment on it [2].
Thanks,
Leo
[1] https://lore.kernel.org/patchwork/cover/1321499/
[2] https://lore.kernel.org/patchwork/cover/1321514/