Re: [PATCH v2 net-next] net: stmmac: Enable EEE HW LPI timer with auto SW/HW switching

From: kernel test robot
Date: Thu Oct 15 2020 - 13:29:12 EST

Hi Voon,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

base: d25e2e9388eda61b6e298585024ee3355f50c493
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add linux-review
git fetch --no-tags linux-review Voon-Weifeng/net-stmmac-Enable-EEE-HW-LPI-timer-with-auto-SW-HW-switching/20201016-000231
git checkout b208a1e7f74a391d1d7c2950e35b97c59af55585
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:297:6: warning: no previous prototype for 'stmmac_lpi_entry_timer_config' [-Wmissing-prototypes]
297 | void stmmac_lpi_entry_timer_config(struct stmmac_priv *priv, bool en)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/stmmac_lpi_entry_timer_config +297 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

> 297 void stmmac_lpi_entry_timer_config(struct stmmac_priv *priv, bool en)
298 {
299 int tx_lpi_timer;
301 /* Clear/set the SW EEE timer flag based on LPI ET enablement */
302 priv->eee_sw_timer_en = en ? 0 : 1;
303 tx_lpi_timer = en ? priv->tx_lpi_timer : 0;
304 stmmac_set_eee_lpi_timer(priv, priv->hw, tx_lpi_timer);
305 }

0-DAY CI Kernel Test Service, Intel Corporation

Attachment: .config.gz
Description: application/gzip