Re: [PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH

From: Jakub Kicinski
Date: Thu Oct 15 2020 - 14:56:53 EST


On Thu, 15 Oct 2020 11:53:08 -0700 Alexei Starovoitov wrote:
> On Thu, Oct 15, 2020 at 9:37 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> > On Wed, 14 Oct 2020 17:17:49 +0800 YueHaibing wrote:
> > > IF CONFIG_BPFILTER_UMH is set, building fails:
> > >
> > > In file included from /usr/include/sys/socket.h:33:0,
> > > from net/bpfilter/main.c:6:
> > > /usr/include/bits/socket.h:390:10: fatal error: asm/socket.h: No such file or directory
> > > #include <asm/socket.h>
> > > ^~~~~~~~~~~~~~
> > > compilation terminated.
> > > scripts/Makefile.userprogs:43: recipe for target 'net/bpfilter/main.o' failed
> > > make[2]: *** [net/bpfilter/main.o] Error 1
> > >
> > > Add missing include path to fix this.
> > >
> > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> >
> > Applied, thank you!
>
> Please revert. The patch makes no sense.

How so? It's using in-tree headers instead of system ones.
Many samples seem to be doing the same thing.

> Also please don't take bpf patches.

You had it marked it as netdev in your patchwork :/