Re: [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index property to indicate a resource

[Marc Kleine-Budde]

On 10/16/20 8:52 AM, Joakim Zhang wrote:
> 
> Hi Marc,
> 
>> -----Original Message-----
>> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
>> Sent: 2020年10月16日 14:20
>> To: Joakim Zhang <qiangqing.zhang@xxxxxxx>; robh+dt@xxxxxxxxxx;
>> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx
>> Cc: devicetree@xxxxxxxxxxxxxxx; Peng Fan <peng.fan@xxxxxxx>; Ying Liu
>> <victor.liu@xxxxxxx>; netdev@xxxxxxxxxxxxxxx; Pankaj Bansal
>> <pankaj.bansal@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
>> linux-can@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>;
>> kernel@xxxxxxxxxxxxxx
>> Subject: Re: [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index property
>> to indicate a resource
>>
>> On 10/16/20 3:43 PM, Joakim Zhang wrote:
>>> For SoCs with SCU support, need setup stop mode via SCU firmware, so
>>> this property can help indicate a resource.
>>>
>>> Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx>
>>> ---
>>>  Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>>> b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>>> index 6af67f5e581c..839c0c0064a2 100644
>>> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>>> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>>> @@ -43,6 +43,10 @@ Optional properties:
>>>  		  0: clock source 0 (oscillator clock)
>>>  		  1: clock source 1 (peripheral clock)
>>>
>>> +- fsl,can-index: The index of CAN instance.
>>> +                 For SoCs with SCU support, need setup stop mode via
>> SCU firmware,
>>> +                 so this property can help indicate a resource.
>>
>> This property is not CAN specific. So the name could be more general.
> 
> How about "fsl,index"?

Maybe something with "scu", as it's specific to the SCU firmware.

I think it's up to Rob's and the DT people.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: OpenPGP digital signature