Re: 5.10-rc0: build error in ipi.c

From: Thomas Gleixner
Date: Fri Oct 16 2020 - 05:03:32 EST


On Fri, Oct 16 2020 at 09:28, Marc Zyngier wrote:

> On 2020-10-16 00:24, Thomas Gleixner wrote:
>> On Thu, Oct 15 2020 at 20:41, Marc Zyngier wrote:
>>> On 2020-10-15 18:18, Pavel Machek wrote:
>>> diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
>>> index 10a5aff4eecc..db923e0da162 100644
>>> --- a/kernel/irq/Kconfig
>>> +++ b/kernel/irq/Kconfig
>>> @@ -81,6 +81,7 @@ config IRQ_FASTEOI_HIERARCHY_HANDLERS
>>>
>>> # Generic IRQ IPI support
>>> config GENERIC_IRQ_IPI
>>> + select IRQ_DOMAIN_HIERARCHY
>>> bool
>>
>> which makes some of the MIPS GENERIC_IRQ_IPI/IRQ_DOMAIN_HIERARCHY
>> Kconfig magic in drivers/irqchip/Kconfig obsolete.
>
> Good point. I'll queue this on top:
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index cd734df57c42..d2a651372e15 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -180,7 +180,6 @@ config IRQ_MIPS_CPU
> select GENERIC_IRQ_CHIP
> select GENERIC_IRQ_IPI if SYS_SUPPORTS_MULTITHREADING
> select IRQ_DOMAIN
> - select IRQ_DOMAIN_HIERARCHY if GENERIC_IRQ_IPI
> select GENERIC_IRQ_EFFECTIVE_AFF_MASK
>
> config CLPS711X_IRQCHIP

There's another one for MIPS_GIC :)