Re: [PATCH net] net: dsa: point out the tail taggers

From: kernel test robot
Date: Fri Oct 16 2020 - 13:25:40 EST


Hi Christian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url: https://github.com/0day-ci/linux/commits/Christian-Eggers/net-dsa-point-out-the-tail-taggers/20201017-003007
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 2ecbc1f684482b4ed52447a39903bd9b0f222898
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/aaa07cad29bf365264beb2c2e2668db83ca31923
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christian-Eggers/net-dsa-point-out-the-tail-taggers/20201017-003007
git checkout aaa07cad29bf365264beb2c2e2668db83ca31923
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

>> net/dsa/tag_ksz.c:126:3: error: 'const struct dsa_device_ops' has no member named 'tail_tag'
126 | .tail_tag = true,
| ^~~~~~~~
>> net/dsa/tag_ksz.c:126:14: warning: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
126 | .tail_tag = true,
| ^~~~
net/dsa/tag_ksz.c:126:14: note: (near initialization for 'ksz8795_netdev_ops.name')
>> net/dsa/tag_ksz.c:126:14: warning: initialized field overwritten [-Woverride-init]
net/dsa/tag_ksz.c:126:14: note: (near initialization for 'ksz8795_netdev_ops.name')
net/dsa/tag_ksz.c:203:3: error: 'const struct dsa_device_ops' has no member named 'tail_tag'
203 | .tail_tag = true,
| ^~~~~~~~
net/dsa/tag_ksz.c:203:14: warning: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
203 | .tail_tag = true,
| ^~~~
net/dsa/tag_ksz.c:203:14: note: (near initialization for 'ksz9477_netdev_ops.name')
net/dsa/tag_ksz.c:203:14: warning: initialized field overwritten [-Woverride-init]
net/dsa/tag_ksz.c:203:14: note: (near initialization for 'ksz9477_netdev_ops.name')

vim +126 net/dsa/tag_ksz.c

119
120 static const struct dsa_device_ops ksz8795_netdev_ops = {
121 .name = "ksz8795",
122 .proto = DSA_TAG_PROTO_KSZ8795,
123 .xmit = ksz8795_xmit,
124 .rcv = ksz8795_rcv,
125 .overhead = KSZ_INGRESS_TAG_LEN,
> 126 .tail_tag = true,
127 };
128

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip