Re: [RFC PATCH] mm: memcg/slab: Stop reparented obj_cgroups from charging root
From: Michal Koutný
Date: Fri Oct 16 2020 - 13:26:40 EST
On Fri, Oct 16, 2020 at 04:05:21PM +0100, Richard Palethorpe <rpalethorpe@xxxxxxx> wrote:
> I'm don't know if that could happen without reparenting. I suppose if
> use_hierarchy=1 then actually this patch will result in root being
> overcharged, so perhaps it should also check for use_hierarchy?
Right, you'd need to distinguish whether the uncharged objcg was
originally (not)charged in the root memcg or it was only reparented to
it. (I originally considered only the genuine root objcgs.)
In this light, homogenous charing to root memcg looks really simpler but
I wonder what other surprises it brings about.
Michal
Attachment:
signature.asc
Description: Digital signature