Re: [PATCH] fs: btrfs: Fix incorrect printf qualifier

[Filipe Manana]

On Wed, Oct 14, 2020 at 10:24 AM Pujin Shi <shipujin.t@xxxxxxxxx> wrote:
>
> This patch addresses a compile warning:
> fs/btrfs/extent-tree.c: In function '__btrfs_free_extent':
> fs/btrfs/extent-tree.c:3187:4: warning: format '%lu' expects argument of type 'long unsigned int', but argument 8 has type 'unsigned int' [-Wformat=]
>
> Fixes: 3b7b6ffa4f8f ("btrfs: extent-tree: kill BUG_ON() in __btrfs_free_extent()")

Btw, that commit id does not exist in Linus' tree, should be 1c2a07f598d5 [1].

> Signed-off-by: Pujin Shi <shipujin.t@xxxxxxxxx>

Other than that it looks good,

Reviewed-by: Filipe Manana <fdmanana@xxxxxxxx>

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1c2a07f598d526e39acbf1837b8d521fc0dab9c5

> ---
>  fs/btrfs/extent-tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index 3b21fee13e77..5fd60b13f4f8 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -3185,7 +3185,7 @@ static int __btrfs_free_extent(struct btrfs_trans_handle *trans,
>                 struct btrfs_tree_block_info *bi;
>                 if (item_size < sizeof(*ei) + sizeof(*bi)) {
>                         btrfs_crit(info,
> -"invalid extent item size for key (%llu, %u, %llu) owner %llu, has %u expect >= %lu",
> +"invalid extent item size for key (%llu, %u, %llu) owner %llu, has %u expect >= %zu",
>                                    key.objectid, key.type, key.offset,
>                                    owner_objectid, item_size,
>                                    sizeof(*ei) + sizeof(*bi));
> --
> 2.18.1
>


-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”