Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes
From: Guido Günther
Date: Sun Oct 18 2020 - 09:01:38 EST
Hi Sam,
On Sat, Oct 17, 2020 at 12:47:36PM +0200, Sam Ravnborg wrote:
> Hi Guido.
>
> On Sat, Oct 17, 2020 at 11:13:07AM +0200, Guido Günther wrote:
> > Hi Sam,
> > On Fri, Oct 16, 2020 at 04:29:16PM +0200, Sam Ravnborg wrote:
> > > Hi Guido.
> > > On Tue, Oct 13, 2020 at 12:32:45PM +0200, Guido Günther wrote:
> > [..snip..]
> > > >
> > > > Changes from v1:
> > > > - As per review comments by Fabio Estevam
> > > > https://lore.kernel.org/dri-devel/CAOMZO5B5ECcConvKej=RcaF8wvOxgq7nUzKJ-ad0aSAOzUqtbQ@xxxxxxxxxxxxxx/
> > > > - Fix typo in commit messages
> > > > - As per review comments by Rob Herring
> > > > https://lore.kernel.org/dri-devel/20200929174624.GA832332@bogus/
> > > > - Don't use an array of reset lines
> > > >
> > > > Guido Günther (3):
> > > > drm/panel: mantix: Don't dereference NULL mode
> > > > drm/panel: mantix: Fix panel reset
> > > > dt-binding: display: Require two resets on mantix panel
> > >
> > > All applied to drm-misc-next and pushed out.
> > > And then I remembered you had commit right - sigh.
> >
> > Thanks! Is there any special care needed to get that into 5.10? The
> > driver landed there in 72967d5616d3f0c714f8eb6c4e258179a9031c45.
>
> As the patches was applied to drm-misc-next the easiet path would
> be to cherry-pick them and apply to drm-misc-fixes.
> dim has cherry-pick support - try to use it rahter than doing it by
> hand.
Does that require any further ACKs or just cherry-pick and push out?
> When you apply to drm-misc-fixes include a Fixes: tag so the tooling
> will pick the patches automagically.
Will do. It was unfortunate that the initial ones didn't get them but
i think the drm merge happened while v2 was out on the list. I'll try
add that relevant information to the cover letter in the future.
Cheers,
-- Guido
>
> In hindsight the patches should have carried a Fixes: tag from a start
> and should have been applied to drm-misc-fixes from a start too.
>
> I have done something like above once or twice but anyway reach out if
> you have questions. Or ask at #dri-devel.
>
> Sam
>