Re: [PATCH v2] iio: adc: mediatek: fix unset field

[Andy Shevchenko]

On Sun, Oct 18, 2020 at 9:31 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Sun, Oct 18, 2020 at 8:16 PM Fabien Parent <fparent@xxxxxxxxxxxx> wrote:
> >
> > dev_comp field is used in a couple of places but it is never set. This
> > results in kernel oops when dereferencing a NULL pointer. Set the
> > `dev_comp` field correctly in the probe function.
> >
> > Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")
> >
> > Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>
>
> Shouldn't be a blank line in the tag block.
>
> I think Jonathan can fix it, but be more careful in the future.

One more serious issue, you forgot to add tags you have gotten in the
previous round.

-- 
With Best Regards,
Andy Shevchenko