RE: [PATCH v1] hv_balloon: disable warning when floor reached
From: Michael Kelley
Date: Sun Oct 18 2020 - 22:58:14 EST
From: Wei Liu <wei.liu@xxxxxxxxxx>
>
> On Tue, Oct 13, 2020 at 11:19:21AM +0200, Olaf Hering wrote:
> > Am Tue, 13 Oct 2020 09:17:17 +0000
> > schrieb Wei Liu <wei.liu@xxxxxxxxxx>:
> >
> > > So ... this patch is not needed anymore?
> >
> > Why? A message is generated every 5 minutes. Unclear why this remained
> > unnoticed since at least v5.3. I have added debug to my distro kernel
> > to see what the involved variable values are. More info later today.
>
> What I mean is you seem to have found a way to configure the system to
> get what you want it to do. It was unclear to me whether this patch is
> absolutely necessary from your last reply.
>
> Some may consider the log informational (like you), some may think it
> warrants a warning (because not enough memory). People also don't seem
> to be particularly bother by it since its introduction in 4.10.
>
> I have no objection to applying this patch. I can pick it up if I don't
> hear objection in the next couple of days.
>
I think we should take the patch. We've had a complaint about the noisy
output from another source as well, so it was on my list of small things
to clean up. Thanks for doing it Olaf.
I'll send a separate Reviewed-by:
Michael