fs/btrfs/volumes.c:888:50: sparse: sparse: incorrect type in argument 1 (different address spaces)

From: kernel test robot
Date: Mon Oct 19 2020 - 00:28:42 EST

Next message:
Previous
Messages

tree: config: s390-randconfig-s032-20201019 compiler: s390-linux-gcc reproduce:
wget # apt-get install sparse
# sparse version: # If you fix the issue, Reported-by: kernel

"sparse warnings: fs/btrfs/volumes.c:374:31: fs/btrfs/volumes.c:374:31: sparse: fs/btrfs/volumes.c:374:31: sparse: fs/btrfs/volumes.c:631:43: fs/btrfs/volumes.c:631:43: sparse: fs/btrfs/volumes.c:631:43: sparse: >> fs/btrfs/volumes.c:888:50: >> fs/btrfs/volumes.c:888:50: fs/btrfs/volumes.c:888:50: sparse: fs/btrfs/volumes.c:963:39: fs/btrfs/volumes.c:963:39: sparse: fs/btrfs/volumes.c:963:39: sparse: fs/btrfs/volumes.c:1018:58: fs/btrfs/volumes.c:1018:58: sparse: fs/btrfs/volumes.c:1018:58: sparse: fs/btrfs/volumes.c:2165:49: fs/btrfs/volumes.c:2165:49: sparse: fs/btrfs/volumes.c:2165:49: sparse: fs/btrfs/volumes.c:2273:41: fs/btrfs/volumes.c:2273:41: sparse: fs/btrfs/volumes.c:2273:41: sparse:
vim +888 fs/btrfs/volumes.c

1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 60999ca4b4033ee David Sterba 60999ca4b4033ee David Sterba 60999ca4b4033ee David Sterba 60999ca4b4033ee David Sterba e124ece53edf3a8 Anand Jain e124ece53edf3a8 Anand Jain 60999ca4b4033ee David Sterba e124ece53edf3a8 Anand Jain 4306a97449f9a0f Anand Jain 4306a97449f9a0f Anand Jain 8a4b83cc8bd75fc Chris Mason 8a4b83cc8bd75fc Chris Mason 7a62d0f07377b51 Nikolay Borisov 606686eeac4550d Josef Bacik 8a4b83cc8bd75fc Chris Mason 3acbcbfc8f06d4a Anand Jain 7239ff4b2be8ec0 Nikolay Borisov 7239ff4b2be8ec0 Nikolay Borisov d1a63002829a4d8 Nikolay Borisov d1a63002829a4d8 Nikolay Borisov 7239ff4b2be8ec0 Nikolay Borisov cc5de4e70256cbf Nikolay Borisov c0d81c7cb236782 Su Yue 7a62d0f07377b51 Nikolay Borisov c0d81c7cb236782 Su Yue cc5de4e70256cbf Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov c6730a0e5778bf2 Su Yue 7a62d0f07377b51 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 8a4b83cc8bd75fc Chris Mason 7239ff4b2be8ec0 Nikolay Borisov 7239ff4b2be8ec0 Nikolay Borisov 7239ff4b2be8ec0 Nikolay Borisov 7239ff4b2be8ec0 Nikolay Borisov 7239ff4b2be8ec0 Nikolay Borisov 7239ff4b2be8ec0 Nikolay Borisov 2208a378f35fea7 Ilya Dryomov e124ece53edf3a8 Anand Jain 2208a378f35fea7 Ilya Dryomov 92900e5160a5444 Al Viro 92900e5160a5444 Al Viro 9c6d173ea6e4c8c Anand Jain c4babc5e38e94e7 Anand Jain 2208a378f35fea7 Ilya Dryomov 8a4b83cc8bd75fc Chris Mason 8a4b83cc8bd75fc Chris Mason 9c6d173ea6e4c8c Anand Jain 09ba3bc9dd15045 Anand Jain 09ba3bc9dd15045 Anand Jain 7a62d0f07377b51 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 1362089d2ad7e20 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 7a62d0f07377b51 Nikolay Borisov 8a4b83cc8bd75fc Chris Mason 443f24fee731703 Miao Xie 8a4b83cc8bd75fc Chris Mason 9c6d173ea6e4c8c Anand Jain 9c6d173ea6e4c8c Anand Jain e124ece53edf3a8 Anand Jain 9c6d173ea6e4c8c Anand Jain 2b82032c34ec405 Yan Zheng 12bd2fc0d2f589f Ilya Dryomov 12bd2fc0d2f589f Ilya Dryomov 12bd2fc0d2f589f Ilya Dryomov 9c6d173ea6e4c8c Anand Jain 8a4b83cc8bd75fc Chris Mason e124ece53edf3a8 Anand Jain 8a4b83cc8bd75fc Chris Mason 606686eeac4550d Josef Bacik 606686eeac4550d Josef Bacik 606686eeac4550d Josef Bacik a425f9d4755a14f David Sterba 9c6d173ea6e4c8c Anand Jain e124ece53edf3a8 Anand Jain 8a4b83cc8bd75fc Chris Mason 606686eeac4550d Josef Bacik 90519d66abbccc2 Arne Jansen 1f78160ce1b1b8e Xiao Guangrong f71717502460c5c Filipe e5e9a5206a171b2 Chris Mason 2b82032c34ec405 Yan Zheng 4306a97449f9a0f Anand Jain 327f18cc7f44bc0 Anand Jain 327f18cc7f44bc0 Anand Jain aa6c0df73e3b3fc Anand Jain aa6c0df73e3b3fc Anand Jain aa6c0df73e3b3fc Anand Jain aa6c0df73e3b3fc Anand Jain 327f18cc7f44bc0 Anand Jain aa6c0df73e3b3fc Anand Jain aa6c0df73e3b3fc Anand Jain aa6c0df73e3b3fc Anand Jain aa6c0df73e3b3fc Anand Jain 327f18cc7f44bc0 Anand Jain 606686eeac4550d Josef Bacik b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain b96de000bc8bc96 Anand Jain 0f23ae74f589304 Chris Mason 0f23ae74f589304 Chris Mason 0f23ae74f589304 Chris Mason 0f23ae74f589304 Chris Mason b96de000bc8bc96 Anand Jain 0f23ae74f589304 Chris Mason 77bdae4d136e167 Anand Jain 77bdae4d136e167 Anand Jain 77bdae4d136e167 Anand Jain 77bdae4d136e167 Anand Jain 77bdae4d136e167 Anand Jain 77bdae4d136e167 Anand Jain 77bdae4d136e167 Anand Jain 9c6d173ea6e4c8c Anand Jain e124ece53edf3a8 Anand Jain 77bdae4d136e167 Anand Jain b96de000bc8bc96 Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain 79dae17d8d44b2d Anand Jain 79dae17d8d44b2d Anand Jain 79dae17d8d44b2d Anand Jain 79dae17d8d44b2d Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain 79dae17d8d44b2d Anand Jain 79dae17d8d44b2d Anand Jain 79dae17d8d44b2d Anand Jain 79dae17d8d44b2d Anand Jain a9261d4125c97ce Anand Jain a9261d4125c97ce Anand Jain 606686eeac4550d Josef Bacik 9c6d173ea6e4c8c Anand Jain 9c6d173ea6e4c8c Anand Jain e124ece53edf3a8 Anand Jain 9c6d173ea6e4c8c Anand Jain 606686eeac4550d Josef Bacik 606686eeac4550d Josef Bacik e6e674bd4d54fe8 Anand Jain cd02dca56442e15 Chris Mason e6e674bd4d54fe8 Anand Jain cd02dca56442e15 Chris Mason 8a4b83cc8bd75fc Chris Mason 8a4b83cc8bd75fc Chris Mason 77bdae4d136e167 Anand Jain 77bdae4d136e167 Anand Jain 77bdae4d136e167 Anand Jain 77bdae4d136e167 Anand Jain 77bdae4d136e167 Anand Jain 77bdae4d136e167 Anand Jain d1a63002829a4d8 Nikolay Borisov 77bdae4d136e167 Anand Jain d1a63002829a4d8 Nikolay Borisov d1a63002829a4d8 Nikolay Borisov d1a63002829a4d8 Nikolay Borisov 77bdae4d136e167 Anand Jain f2788d2f76cafef Anand Jain f2788d2f76cafef Anand Jain 9c6d173ea6e4c8c Anand Jain e124ece53edf3a8 Anand Jain 8a4b83cc8bd75fc Chris Mason 8a4b83cc8bd75fc Chris Mason
:::::: The code at :::::: 606686eeac4550d2212b
:::::: TO: Josef Bacik :::::: CC: Chris Mason
---
0-DAY CI Kernel Test Attachment: Description: application/gzip Sameer Pujar: "Re: [PATCH v4 09/15] ASoC: dt-bindings: audio-graph: Convert bindings to json-schema" message: Srikar Dronamraju: "[PATCH 2/2] powerpc/smp: Use GFP_ATOMIC while allocating tmp mask" sorted by: [ date ] [ thread ] [ subject ] [ author ] href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
50c42131554d9ccc566b8
76fe1007dbba59d13881b btrfs: annotate device name rcu_string with __rcu
(attached as .config)
(GCC) 9.3.0
href="https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
v0.6.3-rc1-2-g368fd9ce-dirty
href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8d1a7aae89dc0c41ffb76fe1007dbba59d13881b">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8d1a7aae89dc0c41ffb76fe1007dbba59d13881b
rel="nofollow" href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
--no-tags linus master
8d1a7aae89dc0c41ffb76fe1007dbba59d13881b
attached .config to linux build tree
COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=s390
kindly add following tag as appropriate
test robot <lkp@xxxxxxxxx>
(new ones prefixed by >>)"
sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct rcu_string *str @@ got struct rcu_string [noderef] __rcu *name @@
expected struct rcu_string *str
got struct rcu_string [noderef] __rcu *name
sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected char const *device_path @@ got char [noderef] __rcu * @@
expected char const *device_path
got char [noderef] __rcu *
sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected char const *s1 @@ got char [noderef] __rcu * @@
sparse: expected char const *s1
got char [noderef] __rcu *
sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct rcu_string *str @@ got struct rcu_string [noderef] __rcu *name @@
expected struct rcu_string *str
got struct rcu_string [noderef] __rcu *name
sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected char const *src @@ got char [noderef] __rcu * @@
expected char const *src
got char [noderef] __rcu *
sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected char const *device_path @@ got char [noderef] __rcu * @@
expected char const *device_path
got char [noderef] __rcu *
sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected char const *device_path @@ got char [noderef] __rcu * @@
expected char const *device_path
got char [noderef] __rcu *
2020-01-10 745
2020-01-10 746 static struct btrfs_fs_devices *find_fsid_reverted_metadata(
2020-01-10 747 struct btrfs_super_block *disk_super)
2020-01-10 748 {
2020-01-10 749 struct btrfs_fs_devices *fs_devices;
2020-01-10 750
2020-01-10 751 /*
2020-01-10 752 * Handle the case where the scanned device is part of an fs whose last
2020-01-10 753 * metadata UUID change reverted it to the original FSID. At the same
2020-01-10 754 * time * fs_devices was first created by another constitutent device
2020-01-10 755 * which didn't fully observe the operation. This results in an
2020-01-10 756 * btrfs_fs_devices created with metadata/fsid different AND
2020-01-10 757 * btrfs_fs_devices::fsid_change set AND the metadata_uuid of the
2020-01-10 758 * fs_devices equal to the FSID of the disk.
2020-01-10 759 */
2020-01-10 760 list_for_each_entry(fs_devices, &fs_uuids, fs_list) {
2020-01-10 761 if (memcmp(fs_devices->fsid, fs_devices->metadata_uuid,
2020-01-10 762 BTRFS_FSID_SIZE) != 0 &&
2020-01-10 763 memcmp(fs_devices->metadata_uuid, disk_super->fsid,
2020-01-10 764 BTRFS_FSID_SIZE) == 0 &&
2020-01-10 765 fs_devices->fsid_change)
2020-01-10 766 return fs_devices;
2020-01-10 767 }
2020-01-10 768
2020-01-10 769 return NULL;
2020-01-10 770 }
2014-03-26 771 /*
2014-03-26 772 * Add new device to list of registered devices
2014-03-26 773 *
2014-03-26 774 * Returns:
2018-01-18 775 * device pointer which was just added or updated when successful
2018-01-18 776 * error pointer when failed
2014-03-26 777 */
2018-01-18 778 static noinline struct btrfs_device *device_list_add(const char *path,
2018-05-29 779 struct btrfs_super_block *disk_super,
2018-05-29 780 bool *new_device_added)
2008-03-24 781 {
2008-03-24 782 struct btrfs_device *device;
2018-10-30 783 struct btrfs_fs_devices *fs_devices = NULL;
2012-06-04 784 struct rcu_string *name;
2008-03-24 785 u64 found_transid = btrfs_super_generation(disk_super);
2018-01-18 786 u64 devid = btrfs_stack_device_id(&disk_super->dev_item);
2018-10-30 787 bool has_metadata_uuid = (btrfs_super_incompat_flags(disk_super) &
2018-10-30 788 BTRFS_FEATURE_INCOMPAT_METADATA_UUID);
2018-10-30 789 bool fsid_change_in_progress = (btrfs_super_flags(disk_super) &
2018-10-30 790 BTRFS_SUPER_FLAG_CHANGING_FSID_V2);
2018-10-30 791
2018-10-30 792 if (fsid_change_in_progress) {
2020-01-10 793 if (!has_metadata_uuid)
2018-10-30 794 fs_devices = find_fsid_inprogress(disk_super);
2020-01-10 795 else
2018-10-30 796 fs_devices = find_fsid_changed(disk_super);
2018-10-30 797 } else if (has_metadata_uuid) {
2020-01-10 798 fs_devices = find_fsid_with_metadata_uuid(disk_super);
2018-10-30 799 } else {
2020-01-10 800 fs_devices = find_fsid_reverted_metadata(disk_super);
2020-01-10 801 if (!fs_devices)
2018-10-30 802 fs_devices = find_fsid(disk_super->fsid, NULL);
2018-10-30 803 }
2018-10-30 804
2018-10-30 805
2008-03-24 806 if (!fs_devices) {
2018-10-30 807 if (has_metadata_uuid)
2018-10-30 808 fs_devices = alloc_fs_devices(disk_super->fsid,
2018-10-30 809 disk_super->metadata_uuid);
2018-10-30 810 else
2018-10-30 811 fs_devices = alloc_fs_devices(disk_super->fsid, NULL);
2018-10-30 812
2013-08-12 813 if (IS_ERR(fs_devices))
2018-01-18 814 return ERR_CAST(fs_devices);
2013-08-12 815
2019-01-27 816 fs_devices->fsid_change = fsid_change_in_progress;
2019-01-27 817
2018-05-29 818 mutex_lock(&fs_devices->device_list_mutex);
2018-04-12 819 list_add(&fs_devices->fs_list, &fs_uuids);
2013-08-12 820
2008-03-24 821 device = NULL;
2008-03-24 822 } else {
2018-05-29 823 mutex_lock(&fs_devices->device_list_mutex);
2019-01-19 824 device = btrfs_find_device(fs_devices, devid,
2019-01-19 825 disk_super->dev_item.uuid, NULL, false);
2018-10-30 826
2018-10-30 827 /*
2018-10-30 828 * If this disk has been pulled into an fs devices created by
2018-10-30 829 * a device which had the CHANGING_FSID_V2 flag then replace the
2018-10-30 830 * metadata_uuid/fsid values of the fs_devices.
2018-10-30 831 */
2020-01-10 832 if (fs_devices->fsid_change &&
2018-10-30 833 found_transid > fs_devices->latest_generation) {
2018-10-30 834 memcpy(fs_devices->fsid, disk_super->fsid,
2018-10-30 835 BTRFS_FSID_SIZE);
2020-01-10 836
2020-01-10 837 if (has_metadata_uuid)
2020-01-10 838 memcpy(fs_devices->metadata_uuid,
2020-01-10 839 disk_super->metadata_uuid,
2020-01-10 840 BTRFS_FSID_SIZE);
2020-01-10 841 else
2018-10-30 842 memcpy(fs_devices->metadata_uuid,
2020-01-10 843 disk_super->fsid, BTRFS_FSID_SIZE);
2018-10-30 844
2018-10-30 845 fs_devices->fsid_change = false;
2018-10-30 846 }
2008-03-24 847 }
2014-07-24 848
2008-03-24 849 if (!device) {
2018-05-29 850 if (fs_devices->opened) {
2018-05-29 851 mutex_unlock(&fs_devices->device_list_mutex);
2018-01-18 852 return ERR_PTR(-EBUSY);
2018-05-29 853 }
2008-11-17 854
2013-08-23 855 device = btrfs_alloc_device(NULL, &devid,
2013-08-23 856 disk_super->dev_item.uuid);
2013-08-23 857 if (IS_ERR(device)) {
2018-05-29 858 mutex_unlock(&fs_devices->device_list_mutex);
2008-03-24 859 /* we can safely leave the fs_devices entry around */
2018-01-18 860 return device;
2008-03-24 861 }
2012-06-04 862
2012-06-04 863 name = rcu_string_strdup(path, GFP_NOFS);
2012-06-04 864 if (!name) {
2018-03-20 865 btrfs_free_device(device);
2018-05-29 866 mutex_unlock(&fs_devices->device_list_mutex);
2018-01-18 867 return ERR_PTR(-ENOMEM);
2008-03-24 868 }
2012-06-04 869 rcu_assign_pointer(device->name, name);
2011-05-23 870
2011-04-20 871 list_add_rcu(&device->dev_list, &fs_devices->devices);
David Borba Manana 2013-08-12 872 fs_devices->num_devices++;
2009-06-10 873
2008-11-17 874 device->fs_devices = fs_devices;
2018-05-29 875 *new_device_added = true;
2018-01-18 876
2018-01-18 877 if (disk_super->label[0])
2019-10-02 878 pr_info(
2019-10-02 879 "BTRFS: device label %s devid %llu transid %llu %s scanned by %s (%d)\n",
2019-10-02 880 disk_super->label, devid, found_transid, path,
2019-10-02 881 current->comm, task_pid_nr(current));
2018-01-18 882 else
2019-10-02 883 pr_info(
2019-10-02 884 "BTRFS: device fsid %pU devid %llu transid %llu %s scanned by %s (%d)\n",
2019-10-02 885 disk_super->fsid, devid, found_transid, path,
2019-10-02 886 current->comm, task_pid_nr(current));
2018-01-18 887
2012-06-04 @888 } else if (!device->name || strcmp(device->name->str, path)) {
2014-07-03 889 /*
2014-07-03 890 * When FS is already mounted.
2014-07-03 891 * 1. If you are here and if the device->name is NULL that
2014-07-03 892 * means this device was missing at time of FS mount.
2014-07-03 893 * 2. If you are here and if the device->name is different
2014-07-03 894 * from 'path' that means either
2014-07-03 895 * a. The same device disappeared and reappeared with
2014-07-03 896 * different name. or
2014-07-03 897 * b. The missing-disk-which-was-replaced, has
2014-07-03 898 * reappeared now.
2014-07-03 899 *
2014-07-03 900 * We must allow 1 and 2a above. But 2b would be a spurious
2014-07-03 901 * and unintentional.
2014-07-03 902 *
2014-07-03 903 * Further in case of 1 and 2a above, the disk at 'path'
2014-07-03 904 * would have missed some transaction when it was away and
2014-07-03 905 * in case of 2a the stale bdev has to be updated as well.
2014-07-03 906 * 2b must not be allowed at all time.
2014-07-03 907 */
2014-07-03 908
2014-07-03 909 /*
2014-09-18 910 * For now, we do allow update to btrfs_fs_device through the
2014-09-18 911 * btrfs dev scan cli after FS has been mounted. We're still
2014-09-18 912 * tracking a problem where systems fail mount by subvolume id
2014-09-18 913 * when we reject replacement on a mounted FS.
2014-07-03 914 */
2014-09-18 915 if (!fs_devices->opened && found_transid < device->generation) {
2014-07-03 916 /*
2014-07-03 917 * That is if the FS is _not_ mounted and if you
2014-07-03 918 * are here, that means there is more than one
2014-07-03 919 * disk with same uuid and devid.We keep the one
2014-07-03 920 * with larger generation number or the last-in if
2014-07-03 921 * generation are equal.
2014-07-03 922 */
2018-05-29 923 mutex_unlock(&fs_devices->device_list_mutex);
2018-01-18 924 return ERR_PTR(-EEXIST);
2014-07-03 925 }
2014-07-03 926
2018-10-15 927 /*
2018-10-15 928 * We are going to replace the device path for a given devid,
2018-10-15 929 * make sure it's the same device if the device is mounted
2018-10-15 930 */
2018-10-15 931 if (device->bdev) {
2018-10-15 932 struct block_device *path_bdev;
2018-10-15 933
2018-10-15 934 path_bdev = lookup_bdev(path);
2018-10-15 935 if (IS_ERR(path_bdev)) {
2018-10-15 936 mutex_unlock(&fs_devices->device_list_mutex);
2018-10-15 937 return ERR_CAST(path_bdev);
2018-10-15 938 }
2018-10-15 939
2018-10-15 940 if (device->bdev != path_bdev) {
2018-10-15 941 bdput(path_bdev);
2018-10-15 942 mutex_unlock(&fs_devices->device_list_mutex);
2018-10-15 943 btrfs_warn_in_rcu(device->fs_info,
2020-09-03 944 "duplicate device %s devid %llu generation %llu scanned by %s (%d)",
2020-09-03 945 path, devid, found_transid,
2020-09-03 946 current->comm,
2020-09-03 947 task_pid_nr(current));
2018-10-15 948 return ERR_PTR(-EEXIST);
2018-10-15 949 }
2018-10-15 950 bdput(path_bdev);
2018-10-15 951 btrfs_info_in_rcu(device->fs_info,
2020-09-03 952 "devid %llu device path %s changed to %s scanned by %s (%d)",
2020-09-03 953 devid, rcu_str_deref(device->name),
2020-09-03 954 path, current->comm,
2020-09-03 955 task_pid_nr(current));
2018-10-15 956 }
2018-10-15 957
2012-06-04 958 name = rcu_string_strdup(path, GFP_NOFS);
2018-05-29 959 if (!name) {
2018-05-29 960 mutex_unlock(&fs_devices->device_list_mutex);
2018-01-18 961 return ERR_PTR(-ENOMEM);
2018-05-29 962 }
2012-06-04 963 rcu_string_free(device->name);
2012-06-04 964 rcu_assign_pointer(device->name, name);
2017-12-04 965 if (test_bit(BTRFS_DEV_STATE_MISSING, &device->dev_state)) {
2010-12-13 966 fs_devices->missing_devices--;
2017-12-04 967 clear_bit(BTRFS_DEV_STATE_MISSING, &device->dev_state);
2010-12-13 968 }
2008-03-24 969 }
2008-03-24 970
2014-07-03 971 /*
2014-07-03 972 * Unmount does not free the btrfs_device struct but would zero
2014-07-03 973 * generation along with most of the other members. So just update
2014-07-03 974 * it back. We need it to pick the disk with largest generation
2014-07-03 975 * (as above).
2014-07-03 976 */
2018-10-30 977 if (!fs_devices->opened) {
2014-07-03 978 device->generation = found_transid;
2018-10-30 979 fs_devices->latest_generation = max_t(u64, found_transid,
2018-10-30 980 fs_devices->latest_generation);
2018-10-30 981 }
2014-07-03 982
2018-01-18 983 fs_devices->total_devices = btrfs_super_num_devices(disk_super);
2018-01-18 984
2018-05-29 985 mutex_unlock(&fs_devices->device_list_mutex);
2018-01-18 986 return device;
2008-03-24 987 }
2008-03-24 988
line 888 was first introduced by commit
f3d621a810407ef5e9bf Btrfs: use rcu to protect device->name
<josef@xxxxxxxxxx>
<chris.mason@xxxxxxxxxx>
Service, Intel Corporation
href="https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
>.config.gz

Next message: Sameer Pujar: "Re: [PATCH v4 09/15] ASoC: dt-bindings: audio-graph: Convert bindings to json-schema"
Previous message: Srikar Dronamraju: "[PATCH 2/2] powerpc/smp: Use GFP_ATOMIC while allocating tmp mask"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]